Resolve "Include name in get highscore"

Closes #54 (closed)

backend/api/highscores.js

@@ -45,8 +45,10 @@ router.get("/gamescore/:playerId/:gameId", (req, res) => {
             //console.log(err);
             return;
           }
-          res.json(result);
-          client.close();
+          addNameToResult(result, db).then(objects => {
+            res.json(objects);
+            client.close();
+          });
         });
     }
   );
@@ -193,6 +195,7 @@ router.get("/gamescores/:gameId", (req, res) => {
 
       if (gameId == null) {
         res.status(400).send("Fields missing");
+        return;
       }
 
       db.collection(collection)
@@ -208,12 +211,49 @@ router.get("/gamescores/:gameId", (req, res) => {
             //console.log(err);
             return;
           }
-          res.json(result);
-          client.close();
+          addNameToResult(result, db).then(objects => {
+            res.json(objects);
+            client.close();
+          });
         });
     }
   );
 });
 
+function addNameToResult(result, db) {
+  return new Promise((resolve, reject) => {
+    const playerIds = result.map(o => o.playerId);
+    db.collection("players")
+      .find({
+        _id: { $in: playerIds }
+      })
+      .project({ name: 1 })
+      .toArray((err, nameresult) => {
+        if (err) {
+          res.sendStatus(500);
+          //console.log(err);
+          return;
+        }
+        nameresult = nameresult.map(doc => {
+          // rename _id => playerId
+          doc.playerId = doc._id;
+          delete doc._id;
+          return doc;
+        });
+        let objects = [];
+        for (let i = 0; i < result.length; i++) {
+          objects.push({
+            ...result[i],
+            ...nameresult.find(
+              itmInner =>
+                String(itmInner.playerId) === String(result[i].playerId)
+            )
+          });
+        }
+        resolve(objects);
+      });
+  });
+}
+
 // Export API routes
 module.exports = router;