Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
T
tdt4242-group16
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Ole-Christian Bjerkeset
tdt4242-group16
Commits
33520704
Commit
33520704
authored
2 years ago
by
Ole-Christian Bjerkeset
Browse files
Options
Downloads
Patches
Plain Diff
long method in users/views refactored
parent
87dd9b98
No related branches found
No related tags found
1 merge request
!7
merging refactor/gallery into master
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
backend/secfit/users/views.py
+16
-11
16 additions, 11 deletions
backend/secfit/users/views.py
with
16 additions
and
11 deletions
backend/secfit/users/views.py
+
16
−
11
View file @
33520704
...
...
@@ -130,23 +130,28 @@ class OfferList(
user
=
self
.
request
.
user
# filtering by status (if provided)
status
=
query_params
.
get
(
"
status
"
,
None
)
if
status
is
not
None
and
self
.
request
is
not
None
:
query_set
=
query_set
.
filter
(
status
=
status
)
if
query_params
.
get
(
"
status
"
,
None
)
is
None
:
query_set
=
Offer
.
objects
.
filter
(
Q
(
owner
=
user
)).
distinct
()
filter_status
(
self
,
query_set
,
query_params
,
user
)
# filtering by category (sent or received)
category
=
query_params
.
get
(
"
category
"
,
None
)
if
category
is
not
None
and
query_params
is
not
None
:
if
category
==
"
sent
"
:
query_set
=
query_set
.
filter
(
owner
=
user
)
elif
category
==
"
received
"
:
query_set
=
query_set
.
filter
(
recipient
=
user
)
filter_category
(
query_params
,
query_set
,
user
)
return
query_set
else
:
return
result
def
filter_status
(
self
,
query_set
,
query_params
,
user
):
status
=
query_params
.
get
(
"
status
"
,
None
)
if
status
is
not
None
and
self
.
request
is
not
None
:
query_set
=
query_set
.
filter
(
status
=
status
)
if
query_params
.
get
(
"
status
"
,
None
)
is
None
:
query_set
=
Offer
.
objects
.
filter
(
Q
(
owner
=
user
)).
distinct
()
def
filter_category
(
query_params
,
query_set
,
user
):
category
=
query_params
.
get
(
"
category
"
,
None
)
if
category
is
not
None
and
query_params
is
not
None
:
if
category
==
"
sent
"
:
query_set
=
query_set
.
filter
(
owner
=
user
)
elif
category
==
"
received
"
:
query_set
=
query_set
.
filter
(
recipient
=
user
)
class
OfferDetail
(
mixins
.
RetrieveModelMixin
,
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment