Skip to content
Snippets Groups Projects
Commit 4a3ab213 authored by Henrik Brun Fevang's avatar Henrik Brun Fevang
Browse files

Fixed errors and updated readme.

parent 12b93e16
No related branches found
No related tags found
No related merge requests found
......@@ -32,3 +32,6 @@ Til testing har vi brukt Jest og Enzyme. Jest gjør testingen både enkel å skr
###Viewport:
Vi har valgt å ikke bruke viewport på applikasjonen vår. Vi implementerte det ikke fra starten av, men brukte heller andre metoder som media-queries for å tilpasse sidene til ulike skjermstørrelser. Da vi implementerte det på slutten av prosjektet, så vi at det ikke utgjorde noen forskjell for layoutet på siden vår, siden vi allerede hadde tatt hensyn til ulike skjermstørrelser. Derfor valgte vi å fjerne det igjen, og det er derfor ikke med på det endelige produktet.
### Error meldinger i konsollen:
Det oppstår en del error meldinger i konsollen som følge av rendering av Victory sitt BarChart. Det ser ut til at y verdier på 0 tolkes som Not a Number. Det er gjort en del debugging for å forstå feilen, men har ikke greid å fikse feilen. Den ser imidlertidig ikke ut til å påvirke utseende eller funksjonaliteten til diagrammet.
......@@ -3,7 +3,6 @@ import ReactDOM from 'react-dom';
import './index.css';
import App from './App';
import {BrowserRouter} from "react-router-dom";
import { listenerCount } from 'process';
ReactDOM.render(
<BrowserRouter>
......
......@@ -20,7 +20,6 @@ export const CommitPage = () => {
i18n.changeLanguage(context.language)
}, [context.language])
if (commitData.isLoading) {
return (
<Loader
......
import React, {FC, useState} from 'react';
import React, {FC} from 'react';
import {Commit} from "../../utils/queryType";
import Select, {SingleValue} from "react-select";
import style from "./commitListPage.module.css";
import {anonymousAnimals} from "../../utils/victory/useVictory"
......
import React, {useEffect, useState} from 'react';
import CommitComponent from "./commitListPage"
import {useGitlabApi} from "../../utils/gitlab_api_service";
import {queryTypes, Commit} from "../../utils/queryType";
import {Commit} from "../../utils/queryType";
import style from "./commitListPage.module.css"
import Loader from "react-loader-spinner";
import GobackButton from '../../components/goBack/goBackButton';
......@@ -13,7 +13,7 @@ const CommitPageWrapper = () => {
const [disablePrev, setDisablePrev] = useState(pageNumber === 1)
const [disableNext, setDisableNext] = useState(false)
let {isLoading, error, data} = useGitlabApi("repository/commits?per_page=20&page=" + pageNumber)
let {isLoading, data} = useGitlabApi("repository/commits?per_page=20&page=" + pageNumber)
function increase() {
......
import { useEffect } from 'react';
import Loader from 'react-loader-spinner';
import GobackButton from '../../components/goBack/goBackButton';
import { BarChart } from '../../components/graphs/barChart/barChart';
......
......@@ -8,7 +8,7 @@ import GobackButton from '../../components/goBack/goBackButton';
const IssuePage = () => {
const {isLoading, error, data} = useGitlabApi(queryTypes.AllIssues)
const {isLoading, data} = useGitlabApi(queryTypes.AllIssues)
return (
<div className={styles.container}>
<GobackButton/>
......
......@@ -9,7 +9,7 @@ import GobackButton from '../../components/goBack/goBackButton';
const OverviewPage = () => {
const slug = window.location.pathname;
const history = useHistory();
const {data, isLoading, error } = useGitlabApi(queryTypes.Languages);
const {data, isLoading} = useGitlabApi(queryTypes.Languages);
return (
......
......@@ -54,8 +54,8 @@ exports[`renders the App Component 1`] = `
<ContextProvider
value={
Object {
"setTestContext": [Function],
"testContext": "Admin",
"language": "no",
"setLanguage": [Function],
}
}
>
......@@ -72,11 +72,21 @@ exports[`renders the App Component 1`] = `
exports[`renders the CommitGraphPage 1`] = `
<div
className="pageContainer"
>
<div
className="header"
>
<GobackButton />
<h1>
Charts for issues
</h1>
<button
className="button"
onClick={[Function]}
>
no
</button>
</div>
<BarChart
title="Commits per day"
/>
......@@ -104,9 +114,9 @@ exports[`renders the CommitListPage 1`] = `
className="Arrow Left"
/>
</button>
<h4>
<h2>
1
</h4>
</h2>
<button
className="Button"
disabled={false}
......@@ -158,7 +168,8 @@ exports[`renders the LandingPage 1`] = `
>
<img
alt="visualization"
src="gitlab.jpeg"
className="picture"
src="data_visualization.jpeg"
style={
Object {
"margin": "30px auto",
......@@ -166,12 +177,6 @@ exports[`renders the LandingPage 1`] = `
}
}
/>
<button
className="defaultButton"
onClick={[Function]}
>
set default values
</button>
<form
onSubmit={[Function]}
>
......@@ -193,15 +198,26 @@ exports[`renders the LandingPage 1`] = `
type="Text"
value=""
/>
<div
className="buttonDiv"
>
<button
className="defaultButton"
onClick={[Function]}
>
Use default values
</button>
<button
className="submitButton"
disabled={true}
type="submit"
>
Use values
Use current values
</button>
</div>
</form>
<ToastContainer
autoClose={3000}
autoClose={2000}
closeButton={[Function]}
closeOnClick={true}
draggable={true}
......@@ -217,7 +233,6 @@ exports[`renders the LandingPage 1`] = `
theme="light"
transition={[Function]}
/>
</form>
</div>
`;
......
......@@ -4,7 +4,7 @@ import Enzyme from 'enzyme';
import ReactSixteenAdapter from 'enzyme-adapter-react-16';
import IssuePage from '../pages/issueListPage/issuePage';
import { IssueGraphPage } from '../pages/issueGraphPage/issueGraphPage';
import OverviewPage from '../pages/overviewPage/Overview';
import OverviewPage from '../pages/overviewPage/overview';
import LandingPage from '../pages/landingPage/landingPage';
import CommitPageWrapper from '../pages/commitListPage/commitPageWrapper';
import { CommitPage } from '../pages/commitGraphPage/commitPage';
......
......@@ -70,9 +70,6 @@ export const useVictory = (initData: Commit[] | Issue[]) => {
let endDate = new Date(endDateInput);
for (let day = startDate; day <= endDate; day.setDate(day.getDate() + 1)) {
anon.anonData.forEach(entry => {
console.log(entry)
})
let amount: number = anon.anonData.filter(entry =>
entry.date.getMonth() === day.getMonth() && entry.date.getDate() === day.getDate()
).length;
......
This diff is collapsed.
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment