Merge branch '269-fix-group-controller-tests' into 'main'

Resolve "fix group controller tests"

Closes #269

See merge request idatt2106-v23-03/backend!217

src/test/java/ntnu/idatt2016/v233/SmartMat/controller/group/FridgeControllerTest.java

@@ -29,8 +29,7 @@ import static org.junit.jupiter.api.Assertions.*;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
-import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*;
-import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;
+
 
 @ExtendWith(MockitoExtension.class)
 public class FridgeControllerTest {
@@ -88,7 +87,7 @@ public class FridgeControllerTest {
         }
     };
 
-    private Authentication adminUser = new Authentication() {
+    private final Authentication adminUser = new Authentication() {
         @Override
         public Collection<? extends GrantedAuthority> getAuthorities() {
             return List.of(new SimpleGrantedAuthority(Authority.ADMIN.name()));

src/test/java/ntnu/idatt2016/v233/SmartMat/controller/group/GroupControllerTest.java

+package ntnu.idatt2016.v233.SmartMat.controller.group;
+
+import ntnu.idatt2016.v233.SmartMat.dto.enums.Authority;
+import ntnu.idatt2016.v233.SmartMat.dto.request.group.ChangeAuthorityRequest;
+import ntnu.idatt2016.v233.SmartMat.dto.response.group.GroupDetailsResponse;
+import ntnu.idatt2016.v233.SmartMat.entity.group.Group;
+import ntnu.idatt2016.v233.SmartMat.entity.group.UserGroupAsso;
+import ntnu.idatt2016.v233.SmartMat.entity.group.UserGroupId;
+import ntnu.idatt2016.v233.SmartMat.entity.user.User;
+import ntnu.idatt2016.v233.SmartMat.service.group.GroupService;
+import ntnu.idatt2016.v233.SmartMat.service.user.UserService;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+import org.springframework.http.HttpStatus;
+import org.springframework.http.ResponseEntity;
+import org.springframework.security.core.Authentication;
+import org.springframework.security.core.GrantedAuthority;
+import org.springframework.security.core.authority.SimpleGrantedAuthority;
+
+import java.util.Collection;
+import java.util.List;
+import java.util.Optional;
+
+import static org.junit.jupiter.api.Assertions.*;
+import static org.mockito.Mockito.when;
+
+@ExtendWith(MockitoExtension.class)
+public class GroupControllerTest {
+
+    @InjectMocks
+    private GroupController groupController;
+
+    @Mock
+    private GroupService groupService;
+
+    @Mock
+    private UserService userService;
+
+    private final Authentication regularUser = new Authentication() {
+        @Override
+        public Collection<? extends GrantedAuthority> getAuthorities() {
+            return List.of(new SimpleGrantedAuthority(Authority.USER.name()));
+        }
+
+        @Override
+        public Object getCredentials() {
+            return null;
+        }
+
+        @Override
+        public Object getDetails() {
+            return null;
+        }
+
+        @Override
+        public Object getPrincipal() {
+            return null;
+        }
+
+        @Override
+        public boolean isAuthenticated() {
+            return true;
+        }
+
+        @Override
+        public void setAuthenticated(boolean isAuthenticated) throws IllegalArgumentException {
+
+        }
+
+        @Override
+        public String getName() {
+            return "test";
+        }
+    };
+
+    private final Authentication adminUser = new Authentication() {
+        @Override
+        public Collection<? extends GrantedAuthority> getAuthorities() {
+            return List.of(new SimpleGrantedAuthority(Authority.ADMIN.name()));
+        }
+
+        @Override
+        public Object getCredentials() {
+            return null;
+        }
+
+        @Override
+        public Object getDetails() {
+            return null;
+        }
+
+        @Override
+        public Object getPrincipal() {
+            return null;
+        }
+
+        @Override
+        public boolean isAuthenticated() {
+            return true;
+        }
+
+        @Override
+        public void setAuthenticated(boolean isAuthenticated) throws IllegalArgumentException {
+
+        }
+
+        @Override
+        public String getName() {
+            return "test";
+        }
+    };
+
+
+    User user;
+
+    Group group;
+
+    @BeforeEach
+    void setUp() {
+        user = User.builder()
+                .username(regularUser.getName())
+                .password("test")
+                .authority(Authority.USER)
+                .build();
+
+        group = Group.builder()
+                .groupId(1L)
+                .groupName("test")
+                .build();
+
+
+        UserGroupAsso userGroupAsso = UserGroupAsso.builder()
+                .id(new UserGroupId(user.getUsername(), group.getGroupId()))
+                .user(user)
+                .group(group)
+                .build();
+
+        group.addUser(userGroupAsso);
+        user.addGroup(userGroupAsso);
+    }
+
+
+
+    @Test
+    void testGetGroup() {
+
+        when(groupService.getUserGroupAssoByUserName(regularUser.getName()))
+                .thenReturn(group.getUser());
+        ResponseEntity<List<UserGroupAsso>> userGroupAssos = groupController.getAllGroupsByUser(regularUser);
+
+        assertSame(userGroupAssos.getStatusCode(), HttpStatus.OK);
+        assertNotNull(userGroupAssos.getBody());
+        assertTrue(userGroupAssos.getBody().contains(group.getUser().get(0)));
+
+    }
+
+    @Test
+    void testGetGroupById(){
+        when(groupService.getGroupById(group.getGroupId())).thenReturn(Optional.ofNullable(group));
+
+        when(groupService.isUserAssociatedWithGroup(regularUser.getName(), group.getGroupId())).thenReturn(true);
+        when(groupService.isUserAssociatedWithGroup(adminUser.getName(), group.getGroupId())).thenReturn(true);
+
+
+        ResponseEntity<?> groupResponseEntity = groupController.getGroupById(group.getGroupId(), regularUser);
+        assertSame(HttpStatus.OK, groupResponseEntity.getStatusCode());
+        assertNotNull(groupResponseEntity.getBody());
+        assertEquals(group.getGroupId(), ((GroupDetailsResponse) groupResponseEntity.getBody()).getGroupId());
+
+        groupResponseEntity = groupController.getGroupById(group.getGroupId(), adminUser);
+
+        assertSame(HttpStatus.OK, groupResponseEntity.getStatusCode());
+        assertNotNull(groupResponseEntity.getBody());
+        assertEquals(group.getGroupId(), ((GroupDetailsResponse) groupResponseEntity.getBody()).getGroupId());
+
+    }
+
+    @Test
+    void testRemoveUserFromGroup(){
+
+        User testUser = User.builder()
+                .username("test2")
+                .password("test")
+                .authority(Authority.USER)
+                .build();
+
+        UserGroupAsso userGroupAsso = UserGroupAsso.builder()
+                .id(new UserGroupId(testUser.getUsername(), group.getGroupId()))
+                .user(testUser)
+                .group(group)
+                .build();
+
+        group.addUser(userGroupAsso);
+        testUser.addGroup(userGroupAsso);
+
+        when(groupService.getGroupById(group.getGroupId())).thenReturn(Optional.ofNullable(group));
+        when(userService.getUserFromUsername(testUser.getUsername())).thenReturn(Optional.of(testUser));
+        when(groupService.isUserAssociatedWithGroup(regularUser.getName(), group.getGroupId())).thenReturn(true);
+
+        when(groupService.getUserGroupAssoAuthority(regularUser.getName(), group.getGroupId())).thenReturn("ADMIN");
+
+        when(userService.getUserFromUsername(regularUser.getName())).thenReturn(Optional.ofNullable(user));
+
+        ResponseEntity<?> groupResponseEntity =
+                groupController.removeUserFromGroup(group.getGroupId(), "test2", regularUser);
+
+        assertSame(HttpStatus.OK, groupResponseEntity.getStatusCode());
+        assertNotNull(groupResponseEntity.getBody());
+        assertEquals("User removed successfully.", groupResponseEntity.getBody());
+
+
+        when(groupService.getUserGroupAssoAuthority(regularUser.getName(), group.getGroupId())).thenReturn("USER");
+
+        when(userService.getUserFromUsername(regularUser.getName())).thenReturn(Optional.ofNullable(user));
+
+        groupResponseEntity =
+                groupController.removeUserFromGroup(group.getGroupId(), "test2", regularUser);
+
+        assertSame(HttpStatus.FORBIDDEN, groupResponseEntity.getStatusCode());
+        assertNull(groupResponseEntity.getBody());
+
+
+        groupResponseEntity =
+                groupController.removeUserFromGroup(group.getGroupId(), "test2", adminUser);
+
+        assertSame(HttpStatus.OK, groupResponseEntity.getStatusCode());
+        assertNotNull(groupResponseEntity.getBody());
+        assertEquals("User removed successfully.", groupResponseEntity.getBody());
+    }
+
+    @Test
+    void shouldChangeAuthority(){
+        when(groupService.getGroupById(group.getGroupId())).thenReturn(Optional.ofNullable(group));
+        when(groupService.isUserAssociatedWithGroup(regularUser.getName(), group.getGroupId())).thenReturn(true);
+        when(groupService.getUserGroupAssoAuthority(regularUser.getName(), group.getGroupId())).thenReturn("ADMIN");
+
+        when(userService.getUserFromUsername(regularUser.getName())).thenReturn(Optional.ofNullable(user));
+
+        ChangeAuthorityRequest changeAuthorityRequest = new ChangeAuthorityRequest(user.getUsername(),
+                group.getGroupId(), "USER");
+
+        ResponseEntity<?> groupResponseEntity =
+                groupController.changeAuthority(changeAuthorityRequest, regularUser);
+
+        assertSame(HttpStatus.OK, groupResponseEntity.getStatusCode());
+        assertNotNull(groupResponseEntity.getBody());
+        assertEquals("Authority changed successfully.", groupResponseEntity.getBody());
+
+        when(groupService.getUserGroupAssoAuthority(regularUser.getName(), group.getGroupId())).thenReturn("USER");
+
+        groupResponseEntity =
+                groupController.changeAuthority(changeAuthorityRequest, regularUser);
+
+        assertSame(HttpStatus.FORBIDDEN, groupResponseEntity.getStatusCode());
+        assertNull(groupResponseEntity.getBody());
+
+    }
+
+    @Test
+    void shouldChangeOpen(){
+        when(groupService.isUserAssociatedWithGroup(regularUser.getName(), group.getGroupId())).thenReturn(true);
+        when(groupService.getUserGroupAssoAuthority(regularUser.getName(), group.getGroupId())).thenReturn("ADMIN");
+
+
+        when(groupService.OpenOrCloseGroup(group.getGroupId())).thenReturn(Optional.of(true));
+
+        ResponseEntity<?> groupResponseEntity =
+                groupController.changeOpenValue(group.getGroupId(), regularUser);
+
+        assertSame(HttpStatus.OK, groupResponseEntity.getStatusCode());
+        assertNotNull(groupResponseEntity.getBody());
+        assertTrue((boolean) groupResponseEntity.getBody());
+
+        when(groupService.getUserGroupAssoAuthority(regularUser.getName(), group.getGroupId())).thenReturn("USER");
+
+        groupResponseEntity =
+                groupController.changeOpenValue(group.getGroupId(), regularUser);
+
+        assertSame(HttpStatus.FORBIDDEN, groupResponseEntity.getStatusCode());
+        assertNull(groupResponseEntity.getBody());
+    }
+    
+
+}
\ No newline at end of file