Feat/view album fields
All threads resolved!
All threads resolved!
Implemented feature view a single albums fields: title, author, tags, description. Did a bit of refactoring in ImageAlbumService: moved tag-related methods to the new TagRepository.
Merge request reports
Activity
- Resolved by Eirik Steira
Great job Eirik! There was little "logic" to this MR so i have few things to comment. Clever adding that Tag service!
My only thought is that I feel you could have moved a lot of the logic/tasks in viewalbum to a service instead. But then again I am not sure of what is the best practice in this case...
added 11 commits
-
55fecb92...12efc012 - 4 commits from branch
dev
- 42888f8e - Add basic flow for populating album fields when viewing single album
- 5af86c29 - Rename dect_textField to picture_dectField in view picture for consistency
- b457c24c - Complete fields album title, tags and description to load and get populated...
- 041d02fa - Add album author and label to view single album
- 9fe8c699 - Edit album field populating methods javadoc in ViewAlbum to reflect intent
- c642fc9a - Shorten album descriptions in LoadDatabase.load to fit in 255 character...
- b17cf62c - Add class javadoc to TagRepository
Toggle commit list-
55fecb92...12efc012 - 4 commits from branch
mentioned in commit f4cfe0b0
Please register or sign in to reply