Skip to content
Snippets Groups Projects

Updated search results page

Merged Updated search results page
searchBugfix into dev
1 unresolved thread
Merged Nicolay Schiøll-Johansen requested to merge searchBugfix into dev
1 unresolved thread

Updates:

  • Page automatically extends based on how many search results you get
  • Page shows total amount of search results
  • Metadata shows inside of a crollpane in order to better fit it

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/main/java/NTNU/IDATT1002/models/Metadata.java
175 ", fileType='" + fileType + '\'' +
176 ", photoDate='" + photoDate + '\'' +
177 ", fileSize='" + fileSize + '\'' +
178 ", fileDimension='" + fileDimension + '\'' +
168 "\nmetadataId=" + metadataId +
169 "\ncamera='" + camera + '\'' +
170 "\nlens='" + lens + '\'' +
171 "\naperture='" + aperture + '\'' +
172 "\nshutterSpeed='" + shutterSpeed + '\'' +
173 "\nISO='" + ISO + '\'' +
174 "\nfocalLength='" + focalLength + '\'' +
175 "\nfileType='" + fileType + '\'' +
176 "\nphotoDate='" + photoDate + '\'' +
177 "\nfileSize='" + fileSize + '\'' +
178 "\nfileDimension='" + fileDimension + '\'' +
179 179 '}';
  • Stian Fjæran Mogen
    Stian Fjæran Mogen @stianfmo ·
    Maintainer

    It might look better without the "{" in the toString(), method when listing the metadata in the application.

  • Eirik Steira
    Eirik Steira @eirsteir ·
    Owner

    Do not use the toString for displaying in UI. This is meant for logging/debugging/representing an object contextually. Additionally the model should not have to consider the UI when displaying itself.

    We should instead create a separate method, perhaps in MetaDataExtractor (I think simon has done this in his branch upload-page).

  • Please register or sign in to reply
  • Stian Fjæran Mogen
    Stian Fjæran Mogen @stianfmo ·
    Maintainer

    Great work! I left one short comment you may take into account if you find it fitting, but its only a suggestion and may be left unchanged. Other than that this it looks great, and I will merge it as soon as the suggestion is resolved!

  • Stian Fjæran Mogen merged

    merged

  • Stian Fjæran Mogen mentioned in commit 8f3e7cd3

    mentioned in commit 8f3e7cd3

    • Please register or sign in to reply