Skip to content
Snippets Groups Projects

Feat/concurrent loading album

Merged Eirik Steira requested to merge feat/concurrent-loading-album into dev
1 unresolved thread

Load albums and images to display in the background to improve responsiveness in explore albums.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 179 private void finalizeProgress() {
    180 progressBar.setProgress(1);
    181 root.getChildren().remove(progressBarContainer);
    182 }
    183
    184 /**
    185 * Crete the HBox for a single album with a placeholder for an image to be added later.
    186 *
    187 * @param album the album to display
    188 * @return HBox with album fields and image placeholder
    189 */
    190 private HBox createAlbumHBox(Album album) {
    191 HBox albumContainer = new HBox();
    192
    193 albumContainer.setId(album.getId().toString());
    194 albumContainer.setPrefWidth(1520);
  • Mads Lundegaard
  • You have done an amazing job here! This was some complex stuff and you still somehow managed to keep it clean, well documented and easy to read. Impressive work! I added a couple minor comments :smile:

    Edited by Mads Lundegaard
  • Eirik Steira added 1 commit

    added 1 commit

    • 3a9fda0d - Rename root VBox to pageRootContainer

    Compare with previous version

  • Mads Lundegaard enabled an automatic merge when the pipeline for 3a9fda0d succeeds

    enabled an automatic merge when the pipeline for 3a9fda0d succeeds

  • Mads Lundegaard mentioned in commit 4f116116

    mentioned in commit 4f116116

  • Please register or sign in to reply
    Loading