Feat/concurrent loading album
1 unresolved thread
1 unresolved thread
Load albums and images to display in the background to improve responsiveness in explore albums.
Merge request reports
Activity
- Resolved by Eirik Steira
179 private void finalizeProgress() { 180 progressBar.setProgress(1); 181 root.getChildren().remove(progressBarContainer); 182 } 183 184 /** 185 * Crete the HBox for a single album with a placeholder for an image to be added later. 186 * 187 * @param album the album to display 188 * @return HBox with album fields and image placeholder 189 */ 190 private HBox createAlbumHBox(Album album) { 191 HBox albumContainer = new HBox(); 192 193 albumContainer.setId(album.getId().toString()); 194 albumContainer.setPrefWidth(1520); This is one of my concerns as well, but I assume @nicolsc will assert this in his page redesign
- Resolved by Eirik Steira
You have done an amazing job here! This was some complex stuff and you still somehow managed to keep it clean, well documented and easy to read. Impressive work! I added a couple minor comments
Edited by Mads Lundegaardenabled an automatic merge when the pipeline for 3a9fda0d succeeds
mentioned in commit 4f116116
Please register or sign in to reply