Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
D
devops-workshop
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
August Skarsfjord Nyheim
devops-workshop
Commits
975d0e37
Commit
975d0e37
authored
4 years ago
by
Amalie Nystuen
Browse files
Options
Downloads
Patches
Plain Diff
Lagt inn kode i generaeteSalt og hashPassword i klassen UserDao, og tester til disse i UserDAOTest.
parent
fc148ccf
No related branches found
No related tags found
No related merge requests found
Pipeline
#115074
passed
4 years ago
Stage: test
Stage: deploy
Changes
2
Pipelines
1
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/main/java/dao/UserDAO.java
+17
-2
17 additions, 2 deletions
src/main/java/dao/UserDAO.java
src/test/java/UserDAOTest.java
+16
-0
16 additions, 0 deletions
src/test/java/UserDAOTest.java
with
33 additions
and
2 deletions
src/main/java/dao/UserDAO.java
+
17
−
2
View file @
975d0e37
...
...
@@ -183,9 +183,18 @@ public class UserDAO {
* @return a random salt
*/
public
byte
[]
generateSalt
()
{
return
null
;
byte
[]
salt
=
new
byte
[
16
];
try
{
SecureRandom
random
=
SecureRandom
.
getInstance
(
"SHA1PRNG"
);
random
.
nextBytes
(
salt
);
}
catch
(
NoSuchAlgorithmException
e
){
e
.
printStackTrace
();
}
return
salt
;
}
/**
* Method to hash a password with salt
* @param password password to be hashed
...
...
@@ -193,7 +202,13 @@ public class UserDAO {
* @return hashedPassword, null if unsuccessful
*/
public
String
hashPassword
(
String
password
,
byte
[]
salt
){
return
null
;
StringBuilder
stringBuilder
=
new
StringBuilder
();
for
(
int
i
=
0
;
i
<
salt
.
length
;
i
++){
stringBuilder
.
append
(
Integer
.
toString
((
salt
[
i
]
&
0xff
)
+
0x100
,
16
).
substring
(
1
));
}
String
hashedPassword
=
password
+
stringBuilder
.
toString
();
return
hashedPassword
;
}
/**
...
...
This diff is collapsed.
Click to expand it.
src/test/java/UserDAOTest.java
+
16
−
0
View file @
975d0e37
...
...
@@ -194,4 +194,20 @@ public class UserDAOTest extends JerseyTest {
assertEquals
(
expectedUsername
,
actualUsername
);
assertNotEquals
(
beforeNewUser
,
afterNewUser
);
}
@Test
public
void
testGenerateSalt
(){
assertNotEquals
(
userDAO
.
generateSalt
(),
userDAO
.
generateSalt
());
}
@Test
public
void
testHashPassword
(){
byte
[]
a
=
{
1
,
2
,
3
,
4
,
5
,
6
,
7
,
8
,
9
,
10
,
11
,
12
,
13
,
14
,
15
,
16
};
byte
[]
b
=
{
1
,
2
,
3
,
4
,
5
,
6
,
7
,
8
,
9
,
10
,
11
,
12
,
13
,
14
,
15
,
1
};
assertEquals
(
userDAO
.
hashPassword
(
"12345"
,
a
),
userDAO
.
hashPassword
(
"12345"
,
a
));
assertNotEquals
(
userDAO
.
hashPassword
(
"123"
,
a
),
userDAO
.
hashPassword
(
"12345"
,
a
));
assertNotEquals
(
userDAO
.
hashPassword
(
"123"
,
a
),
userDAO
.
hashPassword
(
"123"
,
b
));
}
}
\ No newline at end of file
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment