Skip to content
Snippets Groups Projects
Commit 95508ded authored by Edvard Dønvold Sjøborg's avatar Edvard Dønvold Sjøborg
Browse files

Update README.md

parent 63313597
No related branches found
No related tags found
No related merge requests found
......@@ -28,8 +28,9 @@ Sessionstorage has been used to saved the selected options for each exhibition p
To make the website responsive we have used media queries and scalable elements. The site scales well for different screen sizes because the SVGs are in a scalable viewbox. We found that iPad aspect ratios are not too far from PC screen aspect ratios, so we have not made specific media queries for tablets. We have queries both for vertical and horizontal phones and have focused on iPhone screen sizes. The vertical queries changes the layout to a strictly vertical one, while the horizontal queries uses more columns and less rowns in the grid to take advantage of the wide aspect ratio.
### Testing
We have tested that our page behaves appropriately in different browsers with different window sizes. When testing mobile screen sizes (vertical and horizontal) we have used the browser built-in inspect mode that represents common screen sizes for mobile phones. We also tested the website on out actual phones during the last meeting and found it worked as intended.
As for snapshot testing, there is one simple snapshot test for rendering the art page. Since the project description specified “Prosjektet skal vise oppsett av og eksempel på testing med Jest - minimum er å ha en snapshottest’’ we included a single snapshot test. This was a learning experience since no one in the group had any experience with testing. To run the test we used jest and react test renderer.
We have tested that our page behaves appropriately in different browsers with different window sizes. When testing mobile screen sizes (vertical and horizontal) we have used the browser built-in inspect mode that represents common screen sizes for mobile phones. We also tested the website on actual phones during the last meeting and found it worked as intended.
Regarding snapshot testing, there is one simple snapshot test for rendering the art page. Since the project description specified “Prosjektet skal vise oppsett av og eksempel på testing med Jest - minimum er å ha en snapshottest" we included a single snapshot test. This was a learning experience since no one in the group had any experience with testing in react. To run the test we used jest and react test renderer.
### Gits
We have used different branches and issues to complement our workflow. If we implemented features that required more than one commit, we would branch off the master branch and implement those changes there. This ensured that the master branch had stable changes. On merges with master, the relevant issues for the merge request should be referenced. Optimally, we would have only referenced the issue on merges, though we have been somewhat inconsistent here.
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment