From 8dddc5b7278073b917fe5a16f4c5a66081db5ca2 Mon Sep 17 00:00:00 2001 From: Adrian Stoica <stoica@ntnu.no> Date: Wed, 2 Nov 2022 17:48:44 +0100 Subject: [PATCH] fix: changes to proper assertion in testAddToDoItem the testAddToDoItem was using asserTrue to check isOverdue between item and the copy the best practice is to use assertEquals --- todolist/core/src/test/java/todolist/core/TodoListTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/todolist/core/src/test/java/todolist/core/TodoListTest.java b/todolist/core/src/test/java/todolist/core/TodoListTest.java index c0b0a09..3f4c20f 100644 --- a/todolist/core/src/test/java/todolist/core/TodoListTest.java +++ b/todolist/core/src/test/java/todolist/core/TodoListTest.java @@ -35,7 +35,7 @@ public class TodoListTest { TodoItem addedItem = newList.iterator().next(); // check that values are correctly copied assertEquals(item.getText(), addedItem.getText()); - assertTrue(item.isOverdue() == addedItem.isOverdue()); + assertEquals(item.isOverdue(),addedItem.isOverdue()); assertEquals(item.getDeadline(), addedItem.getDeadline()); } -- GitLab