From b00b4d9c84b41f62026d093d07cf356cd5bc9d2d Mon Sep 17 00:00:00 2001 From: Sigurd <sigurd1994@hotmail.com> Date: Mon, 4 Apr 2022 12:12:12 +0200 Subject: [PATCH] Extracted duplicated code --- frontend/www/scripts/exercise.js | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/frontend/www/scripts/exercise.js b/frontend/www/scripts/exercise.js index 24ef186..b7c04d9 100644 --- a/frontend/www/scripts/exercise.js +++ b/frontend/www/scripts/exercise.js @@ -26,7 +26,6 @@ class MuscleGroup { } getMuscleGroupType = () => { - console.log(this.type, "SWIOEFIWEUFH") return this.type; } } @@ -49,13 +48,17 @@ function handleCancelButtonDuringEdit() { if (oldFormData.has("muscleGroup")) form.muscleGroup.value = oldFormData.get("muscleGroup"); if (oldFormData.has("unit")) form.unit.value = oldFormData.get("unit"); + deleteFormData(); + +} + +function deleteFormData() { oldFormData.delete("name"); oldFormData.delete("description"); oldFormData.delete("duration"); oldFormData.delete("calories"); oldFormData.delete("muscleGroup"); oldFormData.delete("unit"); - } function handleCancelButtonDuringCreate() { @@ -160,8 +163,6 @@ async function updateExercise(id) { return; } muscleGroupSelector.setAttribute("disabled", "") - // duplicate code from handleCancelButtonDuringEdit - // you should refactor this setReadOnly(true, "#form-exercise"); okButton.className += " hide"; deleteButton.className += " hide"; @@ -170,12 +171,7 @@ async function updateExercise(id) { cancelButton.removeEventListener("click", handleCancelButtonDuringEdit); - oldFormData.delete("name"); - oldFormData.delete("description"); - oldFormData.delete("duration"); - oldFormData.delete("calories"); - oldFormData.delete("muscleGroup"); - oldFormData.delete("unit"); + deleteFormData(); } window.addEventListener("DOMContentLoaded", async () => { -- GitLab