From 8f7edadfa335f73b76b24788c4915d276fa2e2a3 Mon Sep 17 00:00:00 2001
From: Adrian Stoica <stoica@ntnu.no>
Date: Fri, 4 Nov 2022 12:38:56 +0100
Subject: [PATCH] chore: renames SuppressFBWarnings to follo best practice

SuppressFBWarnings renamed too SuppressFindBugsWarnings
removes also a last standing checkstyle warning
---
 ...{SuppressFBWarnings.java => SuppressFindBugsWarnings.java} | 2 +-
 .../fxutil/src/main/java/fxutil/doc/FileMenuController.java   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
 rename todolist/fxutil/src/main/java/fxutil/{SuppressFBWarnings.java => SuppressFindBugsWarnings.java} (92%)

diff --git a/todolist/fxutil/src/main/java/fxutil/SuppressFBWarnings.java b/todolist/fxutil/src/main/java/fxutil/SuppressFindBugsWarnings.java
similarity index 92%
rename from todolist/fxutil/src/main/java/fxutil/SuppressFBWarnings.java
rename to todolist/fxutil/src/main/java/fxutil/SuppressFindBugsWarnings.java
index 72071ed..e90f793 100644
--- a/todolist/fxutil/src/main/java/fxutil/SuppressFBWarnings.java
+++ b/todolist/fxutil/src/main/java/fxutil/SuppressFindBugsWarnings.java
@@ -8,7 +8,7 @@ import java.lang.annotation.RetentionPolicy;
  * Must have this specific name to be considered by spotbugs.
  */
 @Retention(RetentionPolicy.CLASS)
-public @interface SuppressFBWarnings {
+public @interface SuppressFindBugsWarnings {
   /**
    * The set of FindBugs warnings that are to be suppressed in
    * annotated element. The value can be a bug category, kind or pattern.
diff --git a/todolist/fxutil/src/main/java/fxutil/doc/FileMenuController.java b/todolist/fxutil/src/main/java/fxutil/doc/FileMenuController.java
index ab3af83..cca4140 100644
--- a/todolist/fxutil/src/main/java/fxutil/doc/FileMenuController.java
+++ b/todolist/fxutil/src/main/java/fxutil/doc/FileMenuController.java
@@ -1,6 +1,6 @@
 package fxutil.doc;
 
-import fxutil.SuppressFBWarnings;
+import fxutil.SuppressFindBugsWarnings;
 import java.io.File;
 import java.io.FileInputStream;
 import java.io.IOException;
@@ -36,7 +36,7 @@ public class FileMenuController {
    *
    * @param documentStorage the document storage
    */
-  @SuppressFBWarnings(
+  @SuppressFindBugsWarnings(
       value = "EI_EXPOSE_REP2", 
       justification = "We intentioanlly don't deep copy documentStorage")
   public void setDocumentStorage(final DocumentStorage<File> documentStorage) {
-- 
GitLab