tdt4242-base merge requestshttps://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests2021-04-19T22:17:13+02:00https://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/45Remove comment and lint2021-04-19T22:17:13+02:00Andreas RimolsrønningRemove comment and linthttps://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/37Reduce complexity and simplify long methods2021-04-19T15:17:57+02:00Einar UvsløkkReduce complexity and simplify long methodshttps://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/41Remove unused method with imports2021-04-19T15:05:11+02:00Andreas RimolsrønningRemove unused method with importshttps://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/40Update variable name to follow naming convention2021-04-19T15:02:44+02:00Andreas RimolsrønningUpdate variable name to follow naming conventionhttps://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/42Add black compatible configuration python linters2021-04-19T14:56:14+02:00Einar UvsløkkAdd black compatible configuration python lintershttps://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/32Short down length of methods2021-04-19T14:55:36+02:00Andreas RimolsrønningShort down length of methodsMethods we have implemented our selfes have been refactored, (fetchHighscores).
Do we also need to shorten down methods we have barely touched, such as workout.js retrieveWorkout()?Methods we have implemented our selfes have been refactored, (fetchHighscores).
Do we also need to shorten down methods we have barely touched, such as workout.js retrieveWorkout()?https://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/39Removed Docstrings And Comments2021-04-19T09:01:55+02:00Andreas N. DigernesRemoved Docstrings And CommentsRemoved some unnecessary docstrings and all comments from files in backend.Removed some unnecessary docstrings and all comments from files in backend.https://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/38If Statement Convention2021-04-19T08:36:37+02:00Andreas N. DigernesIf Statement Conventionhttps://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/36Refactor frontend dead code2021-04-19T08:26:59+02:00Andreas RimolsrønningRefactor frontend dead codeRemoved dead code from files that we have touched but are not directly a new featureRemoved dead code from files that we have touched but are not directly a new featurehttps://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/35Refactor front end comments2021-04-19T08:26:20+02:00Andreas RimolsrønningRefactor front end commentsRemoved comments from files that we have touched but are not directly a new featureRemoved comments from files that we have touched but are not directly a new featurehttps://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/33Refactored API2021-04-16T22:12:46+02:00Andreas N. DigernesRefactored APIhttps://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/28Remove feature envy from backend2021-04-16T21:05:48+02:00Einar UvsløkkRemove feature envy from backendReduce coupling between modules by moving code related to user
authentication from the workouts module to the users module.Reduce coupling between modules by moving code related to user
authentication from the workouts module to the users module.https://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/30Frontend/refactor/duplicate code2021-04-16T18:52:41+02:00Andreas RimolsrønningFrontend/refactor/duplicate codeDuplicate fetchAllExercises() removed, and fetchExerciseTypes() removed since it essentially does the same as fetchAllExercises()Duplicate fetchAllExercises() removed, and fetchExerciseTypes() removed since it essentially does the same as fetchAllExercises()https://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/27Remove dead code from backend2021-04-14T20:16:51+02:00Einar UvsløkkRemove dead code from backendRemove unused variables and unused import statementsRemove unused variables and unused import statementshttps://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/25Removed Comments in Files for Backend2021-04-14T20:11:49+02:00Andreas N. DigernesRemoved Comments in Files for BackendComments removed from code.Comments removed from code.https://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/26Refactor code smell dead code2021-04-14T20:10:44+02:00Andreas RimolsrønningRefactor code smell dead codehttps://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/24Refactor code smell comments2021-04-14T20:08:54+02:00Andreas RimolsrønningRefactor code smell commentshttps://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/23Format backend code2021-04-13T10:10:54+02:00Einar UvsløkkFormat backend codeBackend code is formatted with
- isort
- docformatter
- blackBackend code is formatted with
- isort
- docformatter
- blackhttps://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/21Add editorconfig and recommended vscode extensions2021-04-13T09:21:15+02:00Einar UvsløkkAdd editorconfig and recommended vscode extensionshttps://gitlab.stud.idi.ntnu.no/andrerim/tdt4242-base/-/merge_requests/22Lint frontend2021-04-13T09:17:52+02:00Andreas RimolsrønningLint frontendLint frontend with eslint and prettierLint frontend with eslint and prettierAndreas RimolsrønningAndreas Rimolsrønning